pgsql: Make pg_promote() detect postmaster death while waiting forprom - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: Make pg_promote() detect postmaster death while waiting forprom
Date
Msg-id E1i66ny-00010W-Nt@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Make pg_promote() detect postmaster death while waiting for promotion to end.

Previously even if postmaster died and WaitLatch() woke up with that event
while pg_promote() was waiting for the standby promotion to finish,
pg_promote() did nothing special and kept waiting until timeout occurred.
This could cause a busy loop.

This patch make pg_promote() return false immediately when postmaster
dies, to avoid such a busy loop.

Back-patch to v12 where pg_promote() was added.

Author: Fujii Masao
Reviewed-by: Michael Paquier
Discussion: https://postgr.es/m/CAHGQGwEs9ROgSp+QF+YdDU+xP8W=CY1k-_Ov-d_Z3JY+to3eXA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/946647f845d0b0762656a8e07055f501c4b29688

Modified Files
--------------
src/backend/access/transam/xlogfuncs.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Make use of generic logging in vacuumlo and oid2name
Next
From: Fujii Masao
Date:
Subject: pgsql: Make pg_promote() detect postmaster death while waiting forprom