pgsql: Fix inconsistencies and typos in the tree, take 9 - Mailing list pgsql-committers

Fix inconsistencies and typos in the tree, take 9

This addresses more issues with code comments, variable names and
unreferenced variables.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/7ab243e0-116d-3e44-d120-76b3df7abefd@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8548ddc61b5858b6466e69f66a6b1a7ea9daef06

Modified Files
--------------
contrib/pg_standby/pg_standby.c                 |  1 -
contrib/pgcrypto/pgp-pgsql.c                    |  2 +-
contrib/pgcrypto/px.h                           |  3 ---
contrib/pgcrypto/sha1.c                         | 10 ----------
contrib/postgres_fdw/postgres_fdw.c             |  2 +-
contrib/sepgsql/sepgsql.h                       |  2 +-
contrib/test_decoding/test_decoding.c           |  2 +-
doc/src/sgml/libpq.sgml                         |  2 +-
doc/src/sgml/ref/set_role.sgml                  |  2 +-
doc/src/sgml/sslinfo.sgml                       |  2 +-
src/backend/access/gin/README                   |  2 +-
src/backend/access/gin/ginbtree.c               |  2 +-
src/backend/access/gist/gistget.c               | 12 ++++++------
src/backend/access/hash/hash_xlog.c             |  2 +-
src/backend/access/hash/hashinsert.c            |  4 ++--
src/backend/access/heap/heapam.c                |  2 +-
src/backend/access/heap/visibilitymap.c         |  2 +-
src/backend/access/nbtree/nbtsort.c             |  2 +-
src/backend/access/transam/README               |  2 +-
src/backend/access/transam/clog.c               |  2 +-
src/backend/access/transam/multixact.c          |  2 +-
src/backend/catalog/aclchk.c                    |  2 +-
src/backend/catalog/information_schema.sql      |  4 ----
src/backend/catalog/objectaddress.c             |  2 +-
src/backend/commands/copy.c                     |  1 -
src/backend/commands/define.c                   |  2 +-
src/backend/commands/prepare.c                  |  2 +-
src/backend/commands/vacuum.c                   |  2 +-
src/backend/executor/nodeWindowAgg.c            |  4 ++--
src/backend/libpq/pqcomm.c                      |  4 ++--
src/backend/nodes/params.c                      |  2 +-
src/backend/nodes/tidbitmap.c                   |  2 +-
src/backend/optimizer/geqo/geqo_selection.c     |  2 +-
src/backend/optimizer/plan/planner.c            |  4 ++--
src/backend/parser/parse_oper.c                 |  2 +-
src/backend/postmaster/pgstat.c                 |  2 +-
src/backend/regex/regcomp.c                     |  1 -
src/backend/replication/logical/reorderbuffer.c |  2 +-
src/backend/storage/ipc/procarray.c             |  1 -
src/backend/storage/ipc/shm_mq.c                |  2 +-
src/backend/storage/lmgr/lock.c                 |  4 ++--
src/backend/storage/lmgr/predicate.c            |  4 ++--
src/backend/utils/adt/genfile.c                 |  2 +-
src/backend/utils/adt/ruleutils.c               |  2 +-
src/backend/utils/mmgr/slab.c                   |  2 +-
src/backend/utils/time/snapmgr.c                |  2 +-
src/bin/initdb/initdb.c                         |  2 +-
src/bin/pg_dump/pg_dump.h                       |  4 ----
src/bin/pg_dump/pg_restore.c                    |  2 --
src/bin/pg_resetwal/pg_resetwal.c               |  4 ++--
src/bin/psql/describe.h                         |  2 +-
src/common/unicode/norm_test.c                  |  2 +-
src/include/access/commit_ts.h                  |  2 +-
src/include/access/gin_private.h                |  4 ++--
src/include/access/hash.h                       |  2 +-
src/include/access/nbtxlog.h                    |  2 +-
src/include/access/xloginsert.h                 |  2 +-
src/include/catalog/catversion.h                |  4 ++--
src/include/commands/extension.h                |  2 +-
src/include/commands/tablecmds.h                |  2 +-
src/include/executor/execExpr.h                 |  2 +-
src/include/mb/pg_wchar.h                       |  2 +-
src/include/parser/parse_func.h                 |  4 ++--
src/include/port/atomics.h                      |  2 +-
src/include/storage/itemptr.h                   |  4 ++--
src/include/storage/off.h                       |  1 -
src/include/storage/proc.h                      |  2 +-
src/include/utils/jsonapi.h                     |  2 +-
src/interfaces/ecpg/ecpglib/execute.c           |  5 +++--
src/interfaces/ecpg/pgtypeslib/datetime.c       |  2 +-
src/interfaces/libpq/fe-connect.c               |  4 ++--
src/interfaces/libpq/fe-exec.c                  |  2 +-
src/interfaces/libpq/fe-misc.c                  |  2 +-
src/interfaces/libpq/libpq-fe.h                 |  8 ++++----
src/interfaces/libpq/libpq-int.h                |  5 +++--
src/pl/plpgsql/src/pl_comp.c                    |  2 +-
src/pl/plpgsql/src/plpgsql.h                    |  2 +-
src/pl/plpython/plpy_procedure.c                |  2 +-
src/test/isolation/Makefile                     |  2 +-
src/tools/msvc/Project.pm                       |  3 +--
80 files changed, 94 insertions(+), 121 deletions(-)