pgsql: Fix tab completion of "SET variable TO|=" to not offer boguscom - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix tab completion of "SET variable TO|=" to not offer boguscom
Date
Msg-id E1hiN9K-0003UK-T4@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix tab completion of "SET variable TO|=" to not offer bogus completions.

Don't think that the context "UPDATE tab SET var =" is a GUC-setting
command.

If we have "SET var =" but the "var" is not a known GUC variable,
don't offer any completions.  The most likely explanation is that
we've misparsed the context and it's not really a GUC-setting command.

Per gripe from Ken Tanzer.  Back-patch to 9.6.  The issue exists
further back, but before 9.6 the code looks very different and it
doesn't actually know whether the "var" name matches anything,
so I desisted from trying to fix it.

Discussion: https://postgr.es/m/CAD3a31XpXzrZA9TT3BqLSHghdTK+=cXjNCE+oL2Zn4+oWoc=qA@mail.gmail.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/074add6ed286a02256a1b03137ff6dd7c8126f25

Modified Files
--------------
src/bin/psql/tab-complete.c | 39 ++++++++++++++++++++++++++-------------
1 file changed, 26 insertions(+), 13 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Simplify psql \d's rule for ordering the indexes of a table.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Remove redundant newlines from error messages