pgsql: tableam: Rename wrapper functions to match callback names. - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: tableam: Rename wrapper functions to match callback names.
Date
Msg-id E1hTxHK-0004bt-5I@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
tableam: Rename wrapper functions to match callback names.

Some of the wrapper functions didn't match the callback names. Many of
them due to staying "consistent" with historic naming of the wrapped
functionality. We decided that for most cases it's more important to
be for tableam to be consistent going forward, than with the past.

The one exception is beginscan/endscan/...  because it'd have looked
odd to have systable_beginscan/endscan/... with a different naming
scheme, and changing the systable_* APIs would have caused way too
much churn (including breaking a lot of external users).

Author: Ashwin Agrawal, with some small additions by Andres Freund
Reviewed-By: Andres Freund
Discussion: https://postgr.es/m/CALfoeiugyrXZfX7n0ORCa4L-m834dzmaE8eFdbNR6PMpetU4Ww@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/73b8c3bd2889fed986044e15aefd0911f96ccdd3

Modified Files
--------------
src/backend/access/heap/heapam.c       | 16 +++----
src/backend/access/table/tableam.c     | 48 +++++++++----------
src/backend/commands/copy.c            | 24 +++++-----
src/backend/commands/createas.c        | 14 +++---
src/backend/commands/matview.c         | 14 +++---
src/backend/commands/tablecmds.c       |  9 ++--
src/backend/commands/trigger.c         | 17 ++++---
src/backend/executor/execMain.c        |  8 ++--
src/backend/executor/execReplication.c | 16 +++----
src/backend/executor/nodeLockRows.c    |  8 ++--
src/backend/executor/nodeModifyTable.c | 80 ++++++++++++++++----------------
src/backend/executor/nodeTidscan.c     |  4 +-
src/backend/utils/adt/tid.c            |  4 +-
src/include/access/tableam.h           | 85 +++++++++++++++++-----------------
14 files changed, 178 insertions(+), 169 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Fix table dump in pg_dump[all] with backends older than 9.5
Next
From: Thomas Munro
Date:
Subject: pgsql: Update copyright year.