pgsql: Fix logical replication's ideas about which type OIDs arebuilt- - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix logical replication's ideas about which type OIDs arebuilt-
Date
Msg-id E1hQIPj-0007LC-KV@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix logical replication's ideas about which type OIDs are built-in.

Only hand-assigned type OIDs should be presumed to match across different
PG servers; those assigned during genbki.pl or during initdb are likely
to change due to addition or removal of unrelated objects.

This means that the cutoff should be FirstGenbkiObjectId (in HEAD)
or FirstBootstrapObjectId (before that), not FirstNormalObjectId.
Compare postgres_fdw's is_builtin() test.

It's likely that this error has no observable consequence in a
normally-functioning system, since ATM the only affected type OIDs are
system catalog rowtypes and information_schema types, which would not
typically be interesting for logical replication.  But you could
probably break it if you tried hard, so back-patch.

Discussion: https://postgr.es/m/15150.1557257111@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/32ebb35128c3d16b64039f6d6774afd96a3d91b9

Modified Files
--------------
src/backend/replication/logical/relation.c  |  2 +-
src/backend/replication/pgoutput/pgoutput.c | 10 +++++++---
2 files changed, 8 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: pgsql: Don't leave behind junk nbtree pages during split.
Next
From: Peter Geoghegan
Date:
Subject: pgsql: Doc: Refer to line pointers as item identifiers.