pgsql: Fix SxactGlobalXmin tracking. - Mailing list pgsql-committers

From Thomas Munro
Subject pgsql: Fix SxactGlobalXmin tracking.
Date
Msg-id E1hOeZh-0003dt-2t@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix SxactGlobalXmin tracking.

Commit bb16aba50 broke the code that maintains SxactGlobalXmin.  It
could get stuck when a well-timed READ ONLY transaction runs.  If
SxactGlobalXmin stops advancing, transactions on the
FinishedSerializableTransactions queue are never cleaned up, so
resources are effectively leaked.  Revert that hunk of the commit.

Also revert another similar hunk that was probably harmless, but
unnecessary and unjustified, relating to the DOOMED flag in case of
RO_SAFE early release.

Author: Thomas Munro
Reported-by: Tom Lane
Discussion: https://postgr.es/m/16170.1557251214%40sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/47a338cfcd67139a1f91892b080934fcfc3aea03

Modified Files
--------------
src/backend/storage/lmgr/predicate.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Fix grammar in error message
Next
From: Etsuro Fujita
Date:
Subject: pgsql: postgres_fdw: Fix cost estimation for aggregate pushdown.