pgsql: Un-hide most cascaded-drop details in regression test results. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Un-hide most cascaded-drop details in regression test results.
Date
Msg-id E1h8CLC-0006is-21@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Un-hide most cascaded-drop details in regression test results.

Now that the ordering of DROP messages ought to be stable everywhere,
we should not need these kluges of hiding DETAIL output just to avoid
unstable ordering.  Hiding it's not great for test coverage, so
let's undo that where possible.

In a small number of places, it's necessary to leave it in, for
example because the output might include a variable pg_temp_nnn
schema name.  I also left things alone in places where the details
would depend on other regression test scripts, e.g. plpython_drop.sql.

Perhaps buildfarm experience will show this to be a bad idea,
but if so I'd like to know why.

Discussion: https://postgr.es/m/E1h6eep-0001Mw-Vd@gemulon.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/940311e4bb32a5fe99155052e41179c88b5d48af

Modified Files
--------------
src/test/regress/expected/alter_generic.out        | 38 ++++++++-
src/test/regress/expected/collate.out              | 18 ++++-
src/test/regress/expected/create_function_3.out    | 23 +++++-
src/test/regress/expected/create_index.out         | 10 ++-
src/test/regress/expected/create_view.out          | 90 +++++++++++++++++++++-
src/test/regress/expected/dependency.out           | 10 ++-
src/test/regress/expected/event_trigger.out        |  6 +-
.../regress/expected/float4-misrounded-input.out   |  9 ++-
src/test/regress/expected/float4.out               |  9 ++-
src/test/regress/expected/float8.out               |  9 ++-
src/test/regress/expected/foreign_data.out         | 32 +++++---
src/test/regress/expected/foreign_key.out          | 10 ++-
src/test/regress/expected/object_address.out       | 19 ++++-
src/test/regress/expected/partition_prune.out      |  4 +-
src/test/regress/expected/privileges.out           |  9 ++-
src/test/regress/expected/rolenames.out            |  7 +-
src/test/regress/expected/rowsecurity.out          | 39 ++++++++--
src/test/regress/expected/rules.out                |  6 +-
src/test/regress/expected/stats_ext.out            |  9 ++-
src/test/regress/expected/truncate.out             |  7 +-
src/test/regress/sql/alter_generic.sql             |  2 -
src/test/regress/sql/collate.sql                   |  1 -
src/test/regress/sql/create_function_3.sql         |  2 -
src/test/regress/sql/create_index.sql              |  4 +-
src/test/regress/sql/create_view.sql               |  1 -
src/test/regress/sql/dependency.sql                |  3 +-
src/test/regress/sql/event_trigger.sql             |  3 -
src/test/regress/sql/float4.sql                    |  5 --
src/test/regress/sql/float8.sql                    |  5 --
src/test/regress/sql/foreign_data.sql              | 11 ---
src/test/regress/sql/foreign_key.sql               |  2 -
src/test/regress/sql/object_address.sql            |  2 -
src/test/regress/sql/partition_prune.sql           |  2 -
src/test/regress/sql/privileges.sql                |  4 -
src/test/regress/sql/rolenames.sql                 |  2 -
src/test/regress/sql/rowsecurity.sql               |  6 --
src/test/regress/sql/rules.sql                     |  2 -
src/test/regress/sql/stats_ext.sql                 |  2 -
src/test/regress/sql/truncate.sql                  |  2 -
39 files changed, 313 insertions(+), 112 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Sort dependent objects before reporting them in DROP ROLE.
Next
From: Andres Freund
Date:
Subject: pgsql: tableam: Use in CREATE TABLE AS and CREATE MATERIALIZED VIEW.