pgsql: Fix yet more portability bugs in integerset and its tests. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Fix yet more portability bugs in integerset and its tests.
Date
Msg-id E1h7McO-0007dD-Ag@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix yet more portability bugs in integerset and its tests.

There were more large constants that needed UINT64CONST. And one variable
was declared as "int", when it needed to be uint64. These bugs were only
visible on 32-bit systems; clearly I should've tested on one, given that
this code does a lot of work with 64-bit integers.

Also, in the test "huge distances" test, the code created some values with
random distances between them, but the test logic didn't take into account
the possibility that the random distance was exactly 1. That never actually
happens with the seed we're using, but let's be tidy.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b5fd4972a3bc758c0b8e8c9cd4aa32bacdeb6605

Modified Files
--------------
src/backend/lib/integerset.c                       | 12 ++++++------
src/test/modules/test_integerset/test_integerset.c |  7 +++++--
2 files changed, 11 insertions(+), 8 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Fix ICU tests for older ICU versions
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Make heap TID a tiebreaker nbtree index column.