pgsql: Error out in pg_checksums on incompatible block size - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Error out in pg_checksums on incompatible block size
Date
Msg-id E1h5ftq-0007OA-PE@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Error out in pg_checksums on incompatible block size

pg_checksums is compiled with a given block size and has a hard
dependency to it per the way checksums are calculated via
checksum_impl.h, and trying to use the tool on a data folder which has
not the same block size would result in incorrect checksum calculations
and/or block read errors, meaning that the data folder is corrupted.
This is harmless as checksums are only checked now, but very confusing
for the user so issue an error properly if the block size used at
compilation and the block size used in the data folder do not match.

Reported-by: Sergei Kornilov
Author: Michael Banck, Michael Paquier
Reviewed-by: Fabien Coelho, Magnus Hagander
Discussion: https://postgr.es/m/20190317054657.GA3357@paquier.xyz
ackpatch-through: 11

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fa3395659561b564051a2bbd3997de8e2923c8e3

Modified Files
--------------
src/bin/pg_checksums/pg_checksums.c | 9 +++++++++
1 file changed, 9 insertions(+)


pgsql-committers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: pgsql: Beautify initialization of JsonValueList and JsonLikeRegexContex
Next
From: Michael Paquier
Date:
Subject: pgsql: Fix pg_rewind when rewinding new database with tables included