pgsql: Move remaining code from tqual.[ch] to heapam.h /heapam_visibil - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Move remaining code from tqual.[ch] to heapam.h /heapam_visibil
Date
Msg-id E1glkfA-0006nu-Pg@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Move remaining code from tqual.[ch] to heapam.h / heapam_visibility.c.

Given these routines are heap specific, and that there will be more
generic visibility support in via table AM, it makes sense to move the
prototypes to heapam.h (routines like HeapTupleSatisfiesVacuum will
not be exposed in a generic fashion, because they are too storage
specific).

Similarly, the code in tqual.c is specific to heap, so moving it into
access/heap/ makes sense.

Author: Andres Freund
Discussion: https://postgr.es/m/20180703070645.wchpu5muyto5n647@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c91560defc57f89f7e88632ea14ae77b5cec78ee

Modified Files
--------------
contrib/pg_visibility/pg_visibility.c              |  1 -
contrib/pgrowlocks/pgrowlocks.c                    |  1 -
contrib/pgstattuple/pgstatapprox.c                 |  2 +-
contrib/pgstattuple/pgstattuple.c                  |  1 -
src/backend/access/heap/Makefile                   |  4 +-
src/backend/access/heap/heapam.c                   |  8 ++--
.../tqual.c => access/heap/heapam_visibility.c}    |  8 ++--
src/backend/access/heap/pruneheap.c                |  1 -
src/backend/access/heap/rewriteheap.c              |  1 -
src/backend/access/heap/tuptoaster.c               |  1 -
src/backend/access/heap/vacuumlazy.c               |  1 -
src/backend/access/index/genam.c                   |  1 -
src/backend/access/spgist/spgvacuum.c              |  2 +-
src/backend/access/transam/transam.c               |  4 +-
src/backend/access/transam/xact.c                  |  8 ++--
src/backend/catalog/index.c                        |  1 -
src/backend/commands/analyze.c                     |  2 +-
src/backend/commands/async.c                       |  2 +-
src/backend/commands/cluster.c                     |  1 -
src/backend/executor/nodeBitmapHeapscan.c          |  1 -
src/backend/executor/nodeModifyTable.c             |  1 -
src/backend/executor/nodeSamplescan.c              |  1 -
src/backend/replication/logical/reorderbuffer.c    |  4 +-
src/backend/replication/logical/snapbuild.c        |  2 +-
src/backend/storage/ipc/procarray.c                |  2 +-
src/backend/storage/lmgr/predicate.c               |  2 +-
src/backend/utils/adt/ri_triggers.c                |  2 +-
src/backend/utils/cache/inval.c                    |  6 +--
src/backend/utils/time/Makefile                    |  2 +-
src/include/access/heapam.h                        | 34 +++++++++++++
src/include/utils/snapshot.h                       |  3 +-
src/include/utils/tqual.h                          | 56 ----------------------
32 files changed, 65 insertions(+), 101 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Remove useless bms_copy step in RelationGetIndexAttrBitmap.
Next
From: Andres Freund
Date:
Subject: pgsql: Rename RelationData.rd_amroutine to rd_indam.