pgsql: Fix up confusion over how to use EXTRA_INSTALL. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix up confusion over how to use EXTRA_INSTALL.
Date
Msg-id E1gi5T1-0003RZ-8u@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix up confusion over how to use EXTRA_INSTALL.

Some makefiles were trying to do this:

temp-install: EXTRA_INSTALL=contrib/test_decoding

but that no longer works as of commit aa019da52: the macro is now
consulted by the checkprep target, one level down, and apparently
gmake doesn't propagate such macro settings recursively.

The problem is masked since 42e61c774 because pgxs.mk also sets up
EXTRA_INSTALL, and correctly applies it to the checkprep target.

Unfortunately I'd not risked back-patching that to before v11.
Since aa019da52 was pushed back to v10, it broke test_decoding
there (the only module for which this actually makes a difference
at present).

Hence, back-patch 42e61c774 to v10.  Also, remove some demonstrably
useless settings of EXTRA_INSTALL in v10 and v11 (they'd already
been cleaned up in HEAD).

Per buildfarm.

Discussion: https://postgr.es/m/CAEepm=1pEJdwv6DSGmOfpX0EaX7L7sT28c1nXpqvQvmLfEWb1g@mail.gmail.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/10ab85254d28a9347390405ee594d1b2f496912f

Modified Files
--------------
contrib/test_decoding/Makefile             | 2 --
src/makefiles/pgxs.mk                      | 4 +++-
src/test/modules/snapshot_too_old/Makefile | 2 --
src/test/recovery/Makefile                 | 2 --
4 files changed, 3 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pgsql: Free pre-modification HeapTuple in ALTER TABLE ... TYPE ...
Next
From: Andres Freund
Date:
Subject: pgsql: Remove heapam.h include made superfluous by b60c3975990.