pgsql: Update pg_upgrade test for reg* to include regrole andregnamesp - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Update pg_upgrade test for reg* to include regrole andregnamesp
Date
Msg-id E1gRS1b-0007fx-21@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Update pg_upgrade test for reg* to include regrole and regnamespace.

When the regrole (0c90f6769) and regnamespace (cb9fa802b) types were
added in 9.5, pg_upgrade's check for reg* types wasn't updated. While
regrole currently is safe, regnamespace is not.

It seems unlikely that anybody uses regnamespace inside catalog tables
across a pg_upgrade, but the tests should be correct nevertheless.

While at it, reorder the types checked in the query to be
alphabetical. Otherwise it's annoying to compare existing and tested
for types.

Author: Andres Freund
Discussion: https://postgr.es/m/037e152a-cb25-3bcb-4f35-bdc9988f8204@2ndQuadrant.com
Backpatch: 9.5-, as regrole/regnamespace

Branch
------
REL9_5_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2bdca80fcc31b44b69628f7ba4b8a3b3ab23f1f1

Modified Files
--------------
src/bin/pg_upgrade/check.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Update pg_upgrade test for reg* to include regrole andregnamesp
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Update pg_upgrade test for reg* to include regrole and regnamesp