pgsql: Update pg_upgrade test for reg* to include regrole andregnamesp - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Update pg_upgrade test for reg* to include regrole andregnamesp
Date
Msg-id E1gRS1V-0007eS-1p@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Update pg_upgrade test for reg* to include regrole and regnamesp
List pgsql-committers
Update pg_upgrade test for reg* to include regrole and regnamespace.

When the regrole (0c90f6769) and regnamespace (cb9fa802b) types were
added in 9.5, pg_upgrade's check for reg* types wasn't updated. While
regrole currently is safe, regnamespace is not.

It seems unlikely that anybody uses regnamespace inside catalog tables
across a pg_upgrade, but the tests should be correct nevertheless.

While at it, reorder the types checked in the query to be
alphabetical. Otherwise it's annoying to compare existing and tested
for types.

Author: Andres Freund
Discussion: https://postgr.es/m/037e152a-cb25-3bcb-4f35-bdc9988f8204@2ndQuadrant.com
Backpatch: 9.5-, as regrole/regnamespace

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ac218aa4f6dff6dfb4bf2675b2d9f2f23da6a7c5

Modified Files
--------------
src/bin/pg_upgrade/check.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: doc: fix wording for plpgsql, add "and"
Next
From: Andres Freund
Date:
Subject: pgsql: Update pg_upgrade test for reg* to include regrole andregnamesp