pgsql: Fix issues with TAP tests of pg_verify_checksums - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Fix issues with TAP tests of pg_verify_checksums
Date
Msg-id E1gOuk4-0001ch-K2@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix issues with TAP tests of pg_verify_checksums

Two issues have been spotted and get fixed here:
- When checking for corrupted files, make sure that pg_verify_checksums
complains about the correct file.  In order to make the logic more
robust, all files created are immediately removed once checks on them
are done.  The error message generated by pg_verify_checksums also now
includes the file name it sees as corrupted.
- Before running corruption-related tests, empty files are generated
which used names mapping with the corrupted files, potentially leading
to conflicts.  So use different set of names for both.

Author: Michael Banck
Discussion: https://postgr.es/m/20181119181119.GC23740@nighthawk.caipicrew.dd-dns.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9685d7383ab48ebe6a6213530f64e4dc67776583

Modified Files
--------------
src/bin/pg_verify_checksums/t/002_actions.pl | 26 +++++++++++++++-----------
1 file changed, 15 insertions(+), 11 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix old TAP tests' method for selecting a valid PGPORT value.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Refine some guc.c help texts