Rejigger materializing and fetching a HeapTuple from a slot.
Previously materializing a slot always returned a HeapTuple. As
current work aims to reduce the reliance on HeapTuples (so other
storage systems can work efficiently), that needs to change. Thus
split the tasks of materializing a slot (i.e. making it independent
from the underlying storage / other memory contexts) from fetching a
HeapTuple from the slot. For brevity, allow to fetch a HeapTuple from
a slot and materializing the slot at the same time, controlled by a
parameter.
For now some callers of ExecFetchSlotHeapTuple, with materialize =
true, expect that changes to the heap tuple will be reflected in the
underlying slot. Those places will be adapted in due course, so while
not pretty, that's OK for now.
Also rename ExecFetchSlotTuple to ExecFetchSlotHeapTupleDatum and
ExecFetchSlotTupleDatum to ExecFetchSlotHeapTupleDatum, as it's likely
that future storage methods will need similar methods. There already
is ExecFetchSlotMinimalTuple, so the new names make the naming scheme
more coherent.
Author: Ashutosh Bapat and Andres Freund, with changes by Amit Khandekar
Discussion: https://postgr.es/m/20181105210039.hh4vvi4vwoq5ba2q@alap3.anarazel.de
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/763f2edd92095b1ca2f4476da073a28505c13820
Modified Files
--------------
contrib/postgres_fdw/postgres_fdw.c | 5 +-
src/backend/commands/copy.c | 4 +-
src/backend/commands/createas.c | 2 +-
src/backend/commands/matview.c | 5 +-
src/backend/commands/trigger.c | 46 ++++++++++++------
src/backend/executor/execMain.c | 2 +-
src/backend/executor/execReplication.c | 4 +-
src/backend/executor/execSRF.c | 2 +-
src/backend/executor/execTuples.c | 85 ++++++++++++++++++++--------------
src/backend/executor/functions.c | 2 +-
src/backend/executor/nodeForeignscan.c | 2 +-
src/backend/executor/nodeHash.c | 24 ++++++++--
src/backend/executor/nodeHashjoin.c | 17 +++++--
src/backend/executor/nodeModifyTable.c | 26 +++++------
src/backend/executor/tqueue.c | 6 ++-
src/include/executor/tuptable.h | 9 ++--
16 files changed, 154 insertions(+), 87 deletions(-)
