pgsql: Prevent generating EEOP_AGG_STRICT_INPUT_CHECK operations whenn - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Prevent generating EEOP_AGG_STRICT_INPUT_CHECK operations whenn
Date
Msg-id E1gJ51l-0002si-Sw@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Prevent generating EEOP_AGG_STRICT_INPUT_CHECK operations when nargs == 0.

This only became a problem with 4c640f4f38, which didn't synchronize
the value agg_strict_input_check.nargs is set to, with the guard
condition for emitting the operation.

Besides such instructions being unnecessary overhead, currently the
LLVM JIT provider doesn't support them. It seems more sensible to
avoid generating such instruction than supporting them. Add assertions
to make it easier to debug a potential further occurance.

Discussion: https://postgr.es/m/2a505161-2727-2473-7c46-591ed108ac52@email.cz
Backpatch: 11-, like 4c640f4f38.

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6eb31cedb316d59bf9c63658868ff0fcddcc085a

Modified Files
--------------
src/backend/executor/execExpr.c     | 2 +-
src/backend/jit/llvm/llvmjit_expr.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Prevent generating EEOP_AGG_STRICT_INPUT_CHECK operations whenn
Next
From: Tom Lane
Date:
Subject: pgsql: Fix unused-variable warning.