Postgres Pro
Downloads
Home   >   mailing lists

pgsql: Fix STRICT check for strict aggregates with NULL ORDER BYcolumn - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Fix STRICT check for strict aggregates with NULL ORDER BYcolumn
Date
Msg-id E1gJ3n6-0001EJ-BM@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Tree view 
Fix STRICT check for strict aggregates with NULL ORDER BY columns.

I (Andres) broke this unintentionally in 69c3936a14, by checking
strictness for all input expressions computed for an aggregate, rather
than just the input for the aggregate transition function.

Reported-By: Ondřej Bouda
Bisected-By: Tom Lane
Diagnosed-By: Andrew Gierth
Discussion: https://postgr.es/m/2a505161-2727-2473-7c46-591ed108ac52@email.cz
Backpatch: 11-, like 69c3936a14

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4c640f4f38d5d68cbe33ddfabbdc56eea8f1e173

Modified Files
--------------
src/backend/executor/execExpr.c          |  2 +-
src/test/regress/expected/aggregates.out | 15 +++++++++++++++
src/test/regress/sql/aggregates.sql      |  7 +++++++
3 files changed, 23 insertions(+), 1 deletion(-)

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Make ts_locale.c's character-type functions cope with UTF-16.
Next
From: Andres Freund
Date:
Subject: pgsql: Fix STRICT check for strict aggregates with NULL ORDER BYcolumn