pgsql: Propagate xactStartTimestamp and stmtStartTimestamp toparallel - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Propagate xactStartTimestamp and stmtStartTimestamp toparallel
Date
Msg-id E1g8p0N-0005yT-4y@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Propagate xactStartTimestamp and stmtStartTimestamp to parallel workers.

Previously, a worker process would establish values for these based on
its own start time.  In v10 and up, this can trivially be shown to cause
misbehavior of transaction_timestamp(), timestamp_in(), and related
functions which are (perhaps unwisely?) marked parallel-safe.  It seems
likely that other behaviors might diverge from what happens in the parent
as well.

It's not as trivial to demonstrate problems in 9.6 or 9.5, but I'm sure
it's still possible, so back-patch to all branches containing parallel
worker infrastructure.

In HEAD only, mark now() and statement_timestamp() as parallel-safe
(other affected functions already were).  While in theory we could
still squeeze that change into v11, it doesn't seem important enough
to force a last-minute catversion bump.

Konstantin Knizhnik, whacked around a bit by me

Discussion: https://postgr.es/m/6406dbd2-5d37-4cb6-6eb2-9c44172c7e7c@postgrespro.ru

Branch
------
REL9_5_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/3c9dd963cec6d4c314bccf74256acc893108a4be

Modified Files
--------------
src/backend/access/transam/parallel.c | 11 +++++++++++
src/backend/access/transam/xact.c     | 36 +++++++++++++++++++++++++++++++----
src/include/access/xact.h             |  1 +
3 files changed, 44 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Dean Rasheed
Date:
Subject: pgsql: Improve the accuracy of floating point statistical aggregates.
Next
From: Tom Lane
Date:
Subject: pgsql: Don't use is_infinite() where isinf() will do.