pgsql: Fix assertion failure when updating full_page_writes forcheckpo - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Fix assertion failure when updating full_page_writes forcheckpo
Date
Msg-id E1g5rAC-0005pp-O1@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix assertion failure when updating full_page_writes for checkpointer.

When the checkpointer receives a SIGHUP signal to update its configuration,
it may need to update the shared memory for full_page_writes and need to
write a WAL record for it.  Now, it is quite possible that the XLOG
machinery has not been initialized by that time and it will lead to
assertion failure while doing that.  Fix is to allow the initialization of
the XLOG machinery outside critical section.

This bug has been introduced by the commit 2c03216d83 which added the XLOG
machinery initialization in RecoveryInProgress code path.

Reported-by: Dilip Kumar
Author: Dilip Kumar
Reviewed-by: Michael Paquier and Amit Kapila
Backpatch-through: 9.5
Discussion: https://postgr.es/m/CAFiTN-u4BA8KXcQUWDPNgaKAjDXC=C2whnzBM8TAcv=stckYUw@mail.gmail.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6c8671bc395c9be44571e424c458b94ec20975d3

Modified Files
--------------
src/backend/access/transam/xlog.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Correct overflow handling in pgbench.
Next
From: Andrew Dunstan
Date:
Subject: Re: pgsql: Build src/port files as a library with -fPIC, and use thatin li