pgsql: Get rid of explicit argument-count markings in tab-complete.c. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Get rid of explicit argument-count markings in tab-complete.c.
Date
Msg-id E1g3W8N-0005kp-Ep@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Get rid of explicit argument-count markings in tab-complete.c.

This replaces the "TailMatchesN" macros with just "TailMatches",
and likewise "HeadMatchesN" becomes "HeadMatches" and "MatchesN"
becomes "Matches".  The various COMPLETE_WITH_LISTn macros are
reduced to COMPLETE_WITH, and the single-item COMPLETE_WITH_CONST
also gets folded into that.  This eliminates a lot of minor
annoyance in writing tab-completion rules.  Usefully, the compiled
code also gets a bit smaller (10% or so, on my machine).

The implementation depends on variadic macros, so we couldn't have
done this before we required C99.

Andres Freund and Thomas Munro; some cosmetic cleanup by me.

Discussion: https://postgr.es/m/d8jo9djvm7h.fsf@dalvik.ping.uio.no

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4f3b38fe2bde72d59b7eab593ff72e0cebd9ecc6

Modified Files
--------------
src/bin/psql/tab-complete.c | 2551 ++++++++++++++++++++-----------------------
src/include/c.h             |   33 +
2 files changed, 1222 insertions(+), 1362 deletions(-)


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pgsql: In v11, disable JIT by default (it's still enabled bydefault in
Next
From: Michael Paquier
Date:
Subject: pgsql: Make GUC wal_sender_timeout user-settable