pgsql: Fix bogus tab-completion rule for CREATE PUBLICATION. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix bogus tab-completion rule for CREATE PUBLICATION.
Date
Msg-id E1g3RZc-0008Ii-0S@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix bogus tab-completion rule for CREATE PUBLICATION.

You can't use "FOR TABLE" as a single Matches argument, because readline
will consider that input to be two words not one.  It's necessary to make
the pattern contain two arguments.

The case accidentally worked anyway because the words_after_create
test fired ... but only for the first such table name.

Noted by Edmund Horner, though this isn't exactly his proposed fix.
Backpatch to v10 where the faulty code came in.

Discussion: https://postgr.es/m/CAMyN-kDe=gBmHgxWwUUaXuwK+p+7g1vChR7foPHRDLE592nJPQ@mail.gmail.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/45a2d45f4ff2e2f1524e7eb3aca9243895eefa8a

Modified Files
--------------
src/bin/psql/tab-complete.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Improve tab completion for ANALYZE, EXPLAIN, and VACUUM.
Next
From: Bruce Momjian
Date:
Subject: pgsql: docs: remove use of escape strings and use bytea hex output