pgsql: Rationalize Query_for_list_of_[relations] query names intab-com - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Rationalize Query_for_list_of_[relations] query names intab-com
Date
Msg-id E1g3OUN-0004N7-Cz@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Rationalize Query_for_list_of_[relations] query names in tab-complete.c.

The previous convention was to use names based on the set of relkinds being
selected for, which was not at all helpful for maintenance, especially
since people had been quite inconsistent about whether to change the names
when they changed the relkinds being selected for.  Instead, use names
based on the functionality we need the relation to have, following the
model established by Query_for_list_of_updatables.

While at it, sort the list of Query constants a bit better; it had the
distinct air of code-assembled-by-dartboard before.

Discussion: https://postgr.es/m/14830.1537481254@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e3b7a6d165d42b59b2432c415d7e4a284a645e89

Modified Files
--------------
src/bin/psql/tab-complete.c | 132 ++++++++++++++++++++++++--------------------
1 file changed, 71 insertions(+), 61 deletions(-)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Use size_t consistently in dsa.{ch}.
Next
From: Tom Lane
Date:
Subject: pgsql: Improve tab completion for ANALYZE, EXPLAIN, and VACUUM.