pgsql: Fix the overrun in hash index metapage for smaller block sizes. - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Fix the overrun in hash index metapage for smaller block sizes.
Date
Msg-id E1fxmQQ-0006Xz-LK@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix the overrun in hash index metapage for smaller block sizes.

The commit 620b49a1 changed the value of HASH_MAX_BITMAPS with the intent
to allow many non-unique values in hash indexes without worrying to reach
the limit of the number of overflow pages.  At that time, this didn't
occur to us that it can overrun the block for smaller block sizes.

Choose the value of HASH_MAX_BITMAPS based on BLCKSZ such that it gives
the same answer as now for the cases where the overrun doesn't occur, and
some other sufficiently-value for the cases where an overrun currently
does occur.  This allows us not to change the behavior in any case that
currently works, so there's really no reason for a HASH_VERSION bump.

Author: Dilip Kumar
Reviewed-by: Amit Kapila
Backpatch-through: 10
Discussion: https://postgr.es/m/CAA4eK1LtF4VmU4mx_+i72ff1MdNZ8XaJMGkt2HV8+uSWcn8t4A@mail.gmail.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/834bce0a5293424d127ab72440b9eacc8841051f

Modified Files
--------------
src/include/access/hash.h | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Andrew Gierth
Date:
Subject: pgsql: Allow extensions to install built as well as unbuilt headers.
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Allow extensions to install built as well as unbuiltheaders.