pgsql: Don't run atexit callbacks in quickdie signal handlers. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Don't run atexit callbacks in quickdie signal handlers.
Date
Msg-id E1fnRBS-0005c6-HM@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Don't run atexit callbacks in quickdie signal handlers.

exit() is not async-signal safe. Even if the libc implementation is, 3rd
party libraries might have installed unsafe atexit() callbacks. After
receiving SIGQUIT, we really just want to exit as quickly as possible, so
we don't really want to run the atexit() callbacks anyway.

The original report by Jimmy Yih was a self-deadlock in startup_die().
However, this patch doesn't address that scenario; the signal handling
while waiting for the startup packet is more complicated. But at least this
alleviates similar problems in the SIGQUIT handlers, like that reported
by Asim R P later in the same thread.

Backpatch to 9.3 (all supported versions).

Discussion:
https://www.postgresql.org/message-id/CAOMx_OAuRUHiAuCg2YgicZLzPVv5d9_H4KrL_OFsFP%3DVPekigA%40mail.gmail.com

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8e4e783ee4f1cb64a46798989e5fd04c7c0a2f53

Modified Files
--------------
src/backend/postmaster/bgworker.c     | 25 +++++++++----------------
src/backend/postmaster/bgwriter.c     | 24 +++++++++---------------
src/backend/postmaster/checkpointer.c | 24 +++++++++---------------
src/backend/postmaster/startup.c      | 24 +++++++++---------------
src/backend/postmaster/walwriter.c    | 24 +++++++++---------------
src/backend/replication/walreceiver.c | 32 +++++++++++++-------------------
src/backend/tcop/postgres.c           | 32 +++++++++++++++++++-------------
7 files changed, 77 insertions(+), 108 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Match RelOptInfos by relids not pointer equality.
Next
From: Tom Lane
Date:
Subject: pgsql: Remove unwanted "garbage cleanup" logic in Makefiles.