pgsql: Make logical WAL sender report streaming state appropriately - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Make logical WAL sender report streaming state appropriately
Date
Msg-id E1fdQIg-00066v-2w@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Make logical WAL sender report streaming state appropriately

WAL senders sending logically-decoded data fail to properly report in
"streaming" state when starting up, hence as long as one extra record is
not replayed, such WAL senders would remain in a "catchup" state, which
is inconsistent with the physical cousin.

This can be easily reproduced by for example using pg_recvlogical and
restarting the upstream server.  The TAP tests have been slightly
modified to detect the failure and strengthened so as future tests also
make sure that a node is in streaming state when waiting for its
catchup.

Backpatch down to 9.4 where this code has been introduced.

Reported-by: Sawada Masahiko
Author: Simon Riggs, Sawada Masahiko
Reviewed-by: Petr Jelinek, Michael Paquier, Vaishnavi Prabakaran
Discussion: https://postgr.es/m/CAD21AoB2ZbCCqOx=bgKMcLrAvs1V0ZMqzs7wBTuDySezTGtMZA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9a7b7adc130a197e5c993a99e6aaa981f9341a35

Modified Files
--------------
src/backend/replication/walsender.c        | 20 +++++++++++++++-----
src/test/perl/PostgresNode.pm              |  5 +++--
src/test/subscription/t/001_rep_changes.pl |  5 +++++
3 files changed, 23 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Mark built-in btree comparison functions as leakproof whereit's
Next
From: Michael Paquier
Date:
Subject: pgsql: Add assertion in expand_vacuum_rel() for non-autovacuum path