pgsql: Correct handling of fsync failures with tar mode ofwalmethods.c - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Correct handling of fsync failures with tar mode ofwalmethods.c
Date
Msg-id E1fXcIg-0005vq-2Y@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Correct handling of fsync failures with tar mode of walmethods.c

This file has been missing the fact that it needs to report back to
callers a proper failure on fsync calls.  I have spotted the one in
tar_finish() while Kuntal has spotted the one in tar_close().

Backpatch down to 10 where this code has been introduced.

Reported by: Michael Paquier, Kuntal Ghosh
Author: Michael Paquier
Reviewed-by: Kuntal Ghosh, Magnus Hagander
Discussion: https://postgr.es/m/20180625024356.GD1146@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d08c3d5197fac1f49cedbd8417e685479ad7439a

Modified Files
--------------
src/bin/pg_basebackup/walmethods.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Update obsolete comments
Next
From: Michael Paquier
Date:
Subject: pgsql: Fix description and documentation related to pg_restore--no-com