pgsql: Properly schema-qualify additional object types ingetObjectDesc - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Properly schema-qualify additional object types ingetObjectDesc
Date
Msg-id E1fLsma-0007ty-9R@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Properly schema-qualify additional object types in getObjectDescription().

Collations, conversions, extended statistics objects (in >= v10),
and all four types of text search objects have schema-qualified names.
getObjectDescription() ignored that and would emit just the base name of
the object, potentially producing wrong or at least highly misleading
output.  Fix it to add the schema name whenever the object is not "visible"
in the current search path, as is the rule for other schema-qualifiable
object types.

Although in common situations the output won't change, this seems to me
(tgl) to be a bug worthy of back-patching, hence do so.

Kyotaro Horiguchi, per a complaint from me

Discussion: https://postgr.es/m/20180522.182020.114074746.horiguchi.kyotaro@lab.ntt.co.jp

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/eb1aa1b46bd919a84e9524ea7178547cc6b93dd8

Modified Files
--------------
src/backend/catalog/objectaddress.c       | 87 ++++++++++++++++++++++++++++---
src/test/regress/expected/alter_table.out | 10 ++--
2 files changed, 84 insertions(+), 13 deletions(-)


pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pgsql: Preserve information on use of git-external-diff
Next
From: Tom Lane
Date:
Subject: pgsql: Fix objectaddress.c code for publication relations.