pgsql: Fix datatype for number of heap tuples during last cleanup - Mailing list pgsql-committers

From Teodor Sigaev
Subject pgsql: Fix datatype for number of heap tuples during last cleanup
Date
Msg-id E1f94wB-0007Ti-MY@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix datatype for number of heap tuples during last cleanup

It appears that new fields introduced in 857f9c36 have inconsistent datatypes:
BTMetaPageData.btm_last_cleanup_num_heap_tuples is of float4 type,
while xl_btree_metadata.last_cleanup_num_heap_tuples is of double type.
IndexVacuumInfo.num_heap_tuples, which is a source of values for
both former fields is of double type.  So, make both those fields in
BTMetaPageData and xl_btree_metadata use float8 type in order to match the
precision of the source.  That shouldn't be double type, because we always
use types with explicit width in WAL.

Patch introduces incompatibility of on-disk format since 857f9c36 commit, but
that versions never was released, so just bump catalog version to avoid
possible confusion.

Author: Alexander Korortkov

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ff4943042f9761fb4e84432da563f43eb3559a3b

Modified Files
--------------
src/include/access/nbtree.h      | 2 +-
src/include/access/nbtxlog.h     | 2 +-
src/include/catalog/catversion.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Teodor Sigaev
Date:
Subject: pgsql: Adjust _bt_insertonpg() comments
Next
From: Teodor Sigaev
Date:
Subject: Re: pgsql: Skip full index scan during cleanup of B-tree indexes whenpossi