pgsql: Improve regression test coverage of expand_tuple(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Improve regression test coverage of expand_tuple().
Date
Msg-id E1f7UBp-0007M8-Ad@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve regression test coverage of expand_tuple().

I was dissatisfied with the code coverage report for expand_tuple() in the
wake of commit 7c44c46de: while better than no coverage at all, it was
still not exercising the core function of inserting out-of-line default
values, nor was the HeapTuple-output path covered.  So far as I can find,
the only code path that reaches the latter at present is EvalPlanQual
fetches for non-locked tables.  Hence, extend eval-plan-qual.spec to
test cases where out-of-line defaults must be inserted into a tuple
fetched from a non-locked table.

Discussion: https://postgr.es/m/87woxi24uw.fsf@ansel.ydns.eu

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b39fd897e0398a6bdc6552daa7cacdf9c0e46d7e

Modified Files
--------------
src/test/isolation/expected/eval-plan-qual.out | 20 ++++++++++++++++++++
src/test/isolation/specs/eval-plan-qual.spec   | 14 ++++++++++++++
2 files changed, 34 insertions(+)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix enforcement of SELECT FOR UPDATE permissions with nestedvie
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Reorganize partitioning code