pgsql: Fix CREATE TABLE / LIKE with bigint identity column - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: Fix CREATE TABLE / LIKE with bigint identity column
Date
Msg-id E1evkoK-0006CD-Ca@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix CREATE TABLE / LIKE with bigint identity column

CREATE TABLE / LIKE with a bigint identity column would fail on
platforms where long is 32 bits.  Copying the sequence values used
makeInteger(), which would truncate the 64-bit sequence data to 32 bits.
To fix, use makeFloat() instead, like the parser.  (This does not
actually make use of floats, but stores the values as strings.)

Bug: #15096
Reviewed-by: Michael Paquier <michael@paquier.xyz>

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c32f44c4a5b27f5055600db1a7374a898f3681df

Modified Files
--------------
src/backend/commands/sequence.c                 | 19 +++++++++++------
src/test/regress/expected/create_table_like.out | 28 ++++++++++++-------------
src/test/regress/sql/create_table_like.sql      |  2 +-
3 files changed, 28 insertions(+), 21 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Avoid having two PKs in a partition
Next
From: Michael Meskes
Date:
Subject: pgsql: Set connection back to NULL after freeing it.