pgsql: Refrain from duplicating data in reorderbuffers - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Refrain from duplicating data in reorderbuffers
Date
Msg-id E1etKFH-0003kw-NN@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Refrain from duplicating data in reorderbuffers

If a walsender exits leaving data in reorderbuffers, the next walsender
that tries to decode the same transaction would append its decoded data
in the same spill files without truncating it first, which effectively
duplicate the data.  Avoid that by removing any leftover reorderbuffer
spill files when a walsender starts.

Backpatch to 9.4; this bug has been there from the very beginning of
logical decoding.

Author: Craig Ringer, revised by me
Reviewed by: Álvaro Herrera, Petr Jelínek, Masahiko Sawada

Branch
------
REL9_4_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6d30e3a2b6b7ce260b3b8bff5ad44c5b6a924b32

Modified Files
--------------
src/backend/replication/logical/reorderbuffer.c | 137 ++++++++++++++----------
1 file changed, 82 insertions(+), 55 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Fix expected error message in test
Next
From: Peter Eisentraut
Date:
Subject: pgsql: doc: Add replication parameter to libpq documentation