pgsql: Make gistvacuumcleanup() count the actual number of indextuples - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Make gistvacuumcleanup() count the actual number of indextuples
Date
Msg-id E1ernSV-0002fz-B1@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Make gistvacuumcleanup() count the actual number of index tuples.

Previously, it just returned the heap tuple count, which might be only an
estimate, and would be completely the wrong thing if the index is partial.
Since this function scans every index page anyway to find free pages,
it's practically free to count the surviving index tuples.  Let's do that
and return an accurate count.

This is easily visible as a wrong reltuples value for a partial GiST
index following VACUUM, so back-patch to all supported branches.

Andrey Borodin, reviewed by Michail Nikolaev

Discussion: https://postgr.es/m/151956654251.6915.675951950408204404.pgcf@coridan.postgresql.org

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/529137cac9a8f0db6cca23a5c305b533cd2dd880

Modified Files
--------------
src/backend/access/gist/gistvacuum.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)


pgsql-committers by date:

Previous
From: Magnus Hagander
Date:
Subject: pgsql: Fix msvc builds for ActivePerl > 5.24
Next
From: Fujii Masao
Date:
Subject: pgsql: Improve tab-completion for ALTER INDEX RESET/SET.