pgsql: Use ereport not elog for some corrupt-HOT-chain reports. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Use ereport not elog for some corrupt-HOT-chain reports.
Date
Msg-id E1erVgS-0005am-BH@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Use ereport not elog for some corrupt-HOT-chain reports.

These errors have been seen in the field in corrupted-data situations.
It seems worthwhile to report them with ERRCODE_DATA_CORRUPTED, rather
than the generic ERRCODE_INTERNAL_ERROR, for the benefit of log monitoring
and tools like amcheck.  However, use errmsg_internal so that the text
strings still aren't translated; it seems unlikely to be worth
translators' time to do so.

Back-patch to 9.3, like the predecessor commit d70cf811f that introduced
these elog calls originally (replacing Asserts).

Peter Geoghegan

Discussion: https://postgr.es/m/CAH2-Wzmn4-Pg-UGFwyuyK-wiTih9j32pwg_7T9iwqXpAUZr=Mg@mail.gmail.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2b2c5aae90fa59260ed54f9ea91ee27d135ef5a1

Modified Files
--------------
src/backend/catalog/index.c | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Relax overly strict sanity check for upgraded ancient databases
Next
From: Andres Freund
Date:
Subject: pgsql: Remove volatile qualifiers from shm_mq.c.