pgsql: Fix up ecpg's configuration so it handles "long long int" inMSV - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix up ecpg's configuration so it handles "long long int" inMSV
Date
Msg-id E1eqn5e-00082J-2l@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix up ecpg's configuration so it handles "long long int" in MSVC builds.

Although configure-based builds correctly define HAVE_LONG_LONG_INT when
appropriate (in both pg_config.h and ecpg_config.h), builds using the MSVC
scripts failed to do so.  This currently has no impact on the backend,
since it uses that symbol nowhere; but it does prevent ecpg from
supporting "long long int".  Fix that.

Also, adjust Solution.pm so that in the constructed ecpg_config.h file,
the "#if (_MSC_VER > 1200)" covers only the LONG_LONG_INT-related
#defines, not the whole file.  AFAICS this was a thinko on somebody's
part: ENABLE_THREAD_SAFETY should always be defined in Windows builds,
and in branches using USE_INTEGER_DATETIMES, the setting of that shouldn't
depend on the compiler version either.  If I'm wrong, I imagine the
buildfarm will say so.

Per bug #15080 from Jonathan Allen; issue diagnosed by Michael Meskes
and Andrew Gierth.  Back-patch to all supported branches.

Discussion: https://postgr.es/m/151935568942.1461.14623890240535309745@wrigleys.postgresql.org

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/fda3e65786763bd43abc576a23035a4cd24ed138

Modified Files
--------------
src/include/pg_config.h.win32 | 5 +++++
src/tools/msvc/Solution.pm    | 3 ++-
2 files changed, 7 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Use the correct tuplestore read pointer in aNamedTuplestoreScan
Next
From: pgsql@postgresql.org
Date:
Subject: pgsql: Tag refs/tags/REL9_6_8 was created