pgsql: Initialize unused ExprEvalStep fields. - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Initialize unused ExprEvalStep fields.
Date
Msg-id E1egFhq-0005nE-KL@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Initialize unused ExprEvalStep fields.
List pgsql-committers
Initialize unused ExprEvalStep fields.

ExecPushExprSlots didn't initialize ExprEvalStep's resvalue/resnull
steps as it didn't use them. That caused wrong valgrind warnings for
an upcoming patch, so zero-intialize.

Also zero-initialize all scratch ExprEvalStep's allocated on the
stack, to avoid issues with similar future omissions of non-critial
data.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fc96c6942551dafa6cb2a6000cbc9b20643e5db3

Modified Files
--------------
src/backend/executor/execExpr.c | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: doc: Clarify pg_upgrade documentation
Next
From: Tom Lane
Date:
Subject: pgsql: Save a few bytes by removing useless last argument toSearchCatC