pgsql: Improve bit perturbation in TupleHashTableHash. - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Improve bit perturbation in TupleHashTableHash.
Date
Msg-id E1egF44-0004s1-C9@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve bit perturbation in TupleHashTableHash.

The changes in b81b5a96f424531b97cdd1dba97d9d1b9c9d372e did not fully
address the issue, because the bit-mixing of the IV into the final
hash-key didn't prevent clustering in the input-data survive in the
output data.

This didn't cause a lot of problems because of the additional growth
conditions added d4c62a6b623d6eef88218158e9fa3cf974c6c7e5. But as we
want to rein those in due to explosive growth in some edges, this
needs to be fixed.

Author: Andres Freund
Discussion: https://postgr.es/m/20171127185700.1470.20362@wrigleys.postgresql.org
Backpatch: 10, where simplehash was introduced

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d18d4bca81f80686238551d1cc460510c3c30544

Modified Files
--------------
src/backend/executor/execGrouping.c        | 11 +++++++++--
src/test/regress/expected/groupingsets.out | 30 +++++++++++++++++-------------
src/test/regress/sql/groupingsets.sql      |  7 ++++---
3 files changed, 30 insertions(+), 18 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Improve bit perturbation in TupleHashTableHash.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: doc: Clarify pg_upgrade documentation