pgsql: PL/Python: Simplify PLyLong_FromInt64 - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: PL/Python: Simplify PLyLong_FromInt64
Date
Msg-id E1ecfBo-0007lL-Kv@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
PL/Python: Simplify PLyLong_FromInt64

We don't actually need two code paths, one for 32 bits and one for 64
bits.  Since the existing code already assumed that "long long" is
available, we can just use PyLong_FromLongLong() for 64 bits as well.
In Python 2.5 and later, PyLong_FromLong() and PyLong_FromLongLong() use
the same code, so there will be no difference for 64-bit platforms.  In
Python 2.4, the code is different, but performance testing showed no
noticeable difference in PL/Python, and that Python version is ancient
anyway.

Discussion: https://www.postgresql.org/message-id/0a02203c-e157-55b2-464e-6087066a1849@2ndquadrant.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/eee50a8d4c389171ad5180568a7221f7e9b28f09

Modified Files
--------------
src/pl/plpython/plpy_typeio.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Allow UPDATE to move rows between partitions.
Next
From: Tom Lane
Date:
Subject: pgsql: Suppress possibly-uninitialized-variable warnings.