pgsql: Add QueryEnvironment to ExplainOneQuery_hook's parameter list. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Add QueryEnvironment to ExplainOneQuery_hook's parameter list.
Date
Msg-id E1eZgSm-00075r-IF@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add QueryEnvironment to ExplainOneQuery_hook's parameter list.

This should have been done in commit 18ce3a4ab, which added that parameter
to ExplainOneQuery, but it was overlooked.  This makes it impossible for
a user of the hook to pass the queryEnv down to ExplainOnePlan.

It's too late to change this API in v10, I suppose, but fortunately
passing NULL to ExplainOnePlan will work in nearly all interesting
cases in v10.  That might not be true forever, so we'd better fix it.

Tatsuro Yamada, reviewed by Thomas Munro

Discussion: https://postgr.es/m/890e8dd9-c1c7-a422-6892-874f5eaee048@lab.ntt.co.jp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4d41b2e0926548e338d20875729a55d41289f867

Modified Files
--------------
src/backend/commands/explain.c | 2 +-
src/include/commands/explain.h | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Cosmetic fix in postgres_fdw.c.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Refactor subscription tests to use PostgresNode'swait_for_catch