[COMMITTERS] pgsql: Fix corner-case errors in brin_doupdate(). - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Fix corner-case errors in brin_doupdate().
Date
Msg-id E1eAIlV-0008RJ-CI@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix corner-case errors in brin_doupdate().

In some cases the BRIN code releases lock on an index page, and later
re-acquires lock and tries to check that the tuple it was working on is
still there.  That check was a couple bricks shy of a load.  It didn't
consider that the page might have turned into a "revmap" page.  (The
samepage code path doesn't call brin_getinsertbuffer(), so it isn't
protected by the checks for revmap status there.)  It also didn't check
whether the tuple offset was now off the end of the linepointer array.
Since commit 24992c6db the latter case is pretty common, but at least
in principle it could have occurred before that.  The net result is
that concurrent updates of a BRIN index could fail with errors like
"invalid index offnum" or "inconsistent range map".

Per report from Tomas Vondra.  Back-patch to 9.5, since this code is
substantially the same in all versions containing BRIN.

Discussion: https://postgr.es/m/10d2b9f9-f427-03b8-8ad9-6af4ecacbee9@2ndquadrant.com

Branch
------
REL9_5_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/43276abc6f7e497bfca2277b9e04585fcd6c25c5

Modified Files
--------------
src/backend/access/brin/brin_pageops.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Fix corner-case errors in brin_doupdate().