[COMMITTERS] pgsql: Fix underqualified cast-target type names in pg_dump and psqlqu - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Fix underqualified cast-target type names in pg_dump and psqlqu
Date
Msg-id E1e9aWb-0002y1-Fu@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix underqualified cast-target type names in pg_dump and psql queries.

Queries running with some non-pg_catalog schema frontmost in their search
path need to be careful to schema-qualify type names that should be sought
in pg_catalog.  Vitaly Burovoy reported an oversight of this sort in
pg_dump's dumpSequence, and grepping detected another one in psql's
describeOneTableDetails, both introduced by sequence-related changes in
v10.  In pg_dump, we can fix things by removing the cast altogether, since
it doesn't really matter what data types are reported for these query
result columns.  Likewise in psql, the query seemed to be working unduly
hard to get a result that's guaranteed to be exactly 'bigint'.

I also changed a couple of occurrences of "::char" similarly.  These are
not bugs, since "char" is a typename keyword and not subject to search_path
rules, but it seems better to use uniform style.

Vitaly Burovoy and Tom Lane

Discussion: https://postgr.es/m/CAKOSWN=ds66zLw2SqkLTM8wbXFgDbc_OdkmT3dJfPT2mE5kipA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/080351466c5a669bf35a323bdec9e296330a5dbb

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 9 ++++++---
src/bin/psql/describe.c   | 4 ++--
2 files changed, 8 insertions(+), 5 deletions(-)


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: [COMMITTERS] pgsql: Don't exaggerate the number of temporary blocks read.
Next
From: Stephen Frost
Date:
Subject: [COMMITTERS] pgsql: Remove inbound links to sql-createuser