[COMMITTERS] pgsql: Fix autovacuum work item error handling - Mailing list pgsql-committers

From Alvaro Herrera
Subject [COMMITTERS] pgsql: Fix autovacuum work item error handling
Date
Msg-id E1e9Cge-00074Z-EI@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix autovacuum work item error handling

In autovacuum's "work item" processing, a few strings were allocated in
the current transaction's memory context, which goes away during error
handling; if an error happened during execution of the work item, the
pfree() calls to clean up afterwards would try to release already-released
memory, possibly leading to a crash.  In branch master, this was already
fixed by commit 335f3d04e4c8, so backpatch that to REL_10_STABLE to fix
the problem there too.

As a secondary problem, verify that the autovacuum worker is connected
to the right database for each work item; otherwise some items would be
discarded by workers in other databases.

Reported-by: Justin Pryzby
Discussion: https://postgr.es/m/20171014035732.GB31726@telsasoft.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/52ca7572c3642ccbb46a619c03efe1928811ceae

Modified Files
--------------
src/backend/postmaster/autovacuum.c | 28 ++++++++++++++++++++--------
1 file changed, 20 insertions(+), 8 deletions(-)


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

pgsql-committers by date:

Previous
From: Magnus Hagander
Date:
Subject: [COMMITTERS] pgsql: Fix typo
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Doc: call out UPDATE syntax change as a v10 compatibilityissue.