[COMMITTERS] pgsql: Fix typcache's failure to treat ranges as container types. - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Fix typcache's failure to treat ranges as container types.
Date
Msg-id E1e5eb8-0008Ld-IW@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix typcache's failure to treat ranges as container types.

Like the similar logic for arrays and records, it's necessary to examine
the range's subtype to decide whether the range type can support hashing.
We can omit checking the subtype for btree-defined operations, though,
since range subtypes are required to have those operations.  (Possibly
that simplification for btree cases led us to overlook that it does
not apply for hash cases.)

This is only an issue if the subtype lacks hash support, which is not
true of any built-in range type, but it's easy to demonstrate a problem
with a range type over, eg, money: you can get a "could not identify
a hash function" failure when the planner is misled into thinking that
hash join or aggregation would work.

This was born broken, so back-patch to all supported branches.

Branch
------
REL9_4_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d1ced611463d9b0fd0a3cb125e3d75d73ab16554

Modified Files
--------------
src/backend/utils/cache/typcache.c       | 50 ++++++++++++++++++++++++++++++++
src/test/regress/expected/rangetypes.out | 12 ++++++++
src/test/regress/sql/rangetypes.sql      | 12 ++++++++
3 files changed, 74 insertions(+)


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Fix misimplementation of typcache logic for extended hashing.
Next
From: Peter Eisentraut
Date:
Subject: [COMMITTERS] pgsql: Convert SGML IDs to lower case