[COMMITTERS] pgsql: Minor code-cleanliness improvements for btree. - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Minor code-cleanliness improvements for btree.
Date
Msg-id E1du2mQ-0007nw-Rs@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Minor code-cleanliness improvements for btree.

Make the btree page-flags test macros (P_ISLEAF and friends) return clean
boolean values, rather than values that might not fit in a bool.  Use them
in a few places that were randomly referencing the flag bits directly.

In passing, change access/nbtree/'s only direct use of BUFFER_LOCK_SHARE to
BT_READ.  (Some think we should go the other way, but as long as we have
BT_READ/BT_WRITE, let's use them consistently.)

Masahiko Sawada, reviewed by Doug Doole

Discussion: https://postgr.es/m/CAD21AoBmWPeN=WBB5Jvyz_Nt3rmW1ebUyAnk3ZbJP3RMXALJog@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/eb5c404b17752ca566947f12cb702438dcccdcb1

Modified Files
--------------
contrib/amcheck/verify_nbtree.c     |  4 ++--
contrib/pgstattuple/pgstattuple.c   |  2 +-
src/backend/access/nbtree/nbtpage.c |  6 +++---
src/backend/access/nbtree/nbtxlog.c |  4 ++--
src/include/access/nbtree.h         | 16 ++++++++--------
5 files changed, 16 insertions(+), 16 deletions(-)


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Make ExplainOpenGroup and ExplainCloseGroup public.
Next
From: Michael Meskes
Date:
Subject: [COMMITTERS] pgsql: Fixed ECPG to correctly handle out-of-scope cursordeclarations