[COMMITTERS] pgsql: Code review for pushing LIMIT through subqueries. - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Code review for pushing LIMIT through subqueries.
Date
Msg-id E1dlEIm-0007FF-PO@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Code review for pushing LIMIT through subqueries.

Minor improvements for commit 1f6d515a6.  We do not need the (rather
expensive) test for SRFs in the targetlist, because since v10 any
such SRFs would appear in separate ProjectSet nodes.  Also, make the
code look more like the existing cases by turning it into a simple
recursion --- the argument that there might be some performance
benefit to contorting the code seems unfounded to me, especially since
any good compiler should turn the tail-recursion into iteration anyway.

Discussion: http://postgr.es/m/CADE5jYLuugnEEUsyW6Q_4mZFYTxHxaVCQmGAsF0yiY8ZDggi-w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3f4c7917b3bc8b421c0c85cb9995974c55e7232b

Modified Files
--------------
src/backend/executor/nodeLimit.c | 58 +++++++++++++++++++++-------------------
1 file changed, 30 insertions(+), 28 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: [COMMITTERS] pgsql: Add minimal regression test for blessed record type transfer.
Next
From: Michael Meskes
Date:
Subject: [COMMITTERS] pgsql: Implement DO CONTINUE action for ECPG WHENEVER statement.