[COMMITTERS] pgsql: Prevent passing down MAKELEVEL/MAKEFLAGS from non-GNU make toGN - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Prevent passing down MAKELEVEL/MAKEFLAGS from non-GNU make toGN
Date
Msg-id E1dfTV1-0002M7-Cn@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Prevent passing down MAKELEVEL/MAKEFLAGS from non-GNU make to GNU make.

FreeBSD's make, for one, sets the MAKELEVEL environment variable when
invoking commands.  In the special Makefile we provide to hand off control
from a non-GNU make to GNU make, this causes GNU make to think it is a
child make invocation rather than top-level.  That interferes with the hack
added in commit dcae5facc to cause the temp-install tree to be made only by
the top-level invocation of gmake.  Unset the variable to prevent that.

Likewise unset MAKEFLAGS, which FreeBSD's make also sets, and which could
easily confuse gmake.  There are no reports of actual trouble from that,
but it seems better to be proactive.

Back-patch to 9.5 where dcae5facc came in.

Thomas Munro, hacked a bit more by me

Discussion: https://postgr.es/m/CAEepm=1ueww35AXTkt1A3gyzZUqv5XCzh8RUNvJZAQAW=eOhVw@mail.gmail.com

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/fc2aafe4a55beb7fe73b9f4cbbb1e49f5b7cb2dd

Modified Files
--------------
Makefile | 1 +
1 file changed, 1 insertion(+)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: [COMMITTERS] pgsql: doc: Add missing pieces to logical replication protocol doc
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Fix handling of container types infind_composite_type_dependenc