[COMMITTERS] pgsql: Fix build on zlib-less environments - Mailing list pgsql-committers

From Alvaro Herrera
Subject [COMMITTERS] pgsql: Fix build on zlib-less environments
Date
Msg-id E1ddLUQ-0007Fs-MR@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix build on zlib-less environments

Commit 4d57e8381677 added support for getting I/O errors out of zlib,
but it introduced a portability problem for systems without zlib.
Repair by wrapping the zlib call inside #ifdef and restore the original
code in the other branch.

This serves to illustrate the inadequacy of the zlib abstraction in
pg_backup_archiver: there is no way to call gzerror() in that
abstraction.  This means that the several places that call GZREAD and
GZWRITE are currently doing error reporting wrongly, but ENOTIME to get
it fixed before next week's release set.

Backpatch to 9.4, like the commit that introduced the problem.

Branch
------
REL9_4_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/69ad12b589e61fd2790ef402532955acef95f7f4

Modified Files
--------------
src/bin/pg_dump/pg_backup_tar.c | 6 ++++++
1 file changed, 6 insertions(+)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: [COMMITTERS] pgsql: Fix lock upgrade hazard in ATExecAttachPartition.
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Fix pg_dump/pg_restore to emit REFRESH MATERIALIZED VIEWcommand