[COMMITTERS] pgsql: Improve ExecModifyTable comments. - Mailing list pgsql-committers

From Robert Haas
Subject [COMMITTERS] pgsql: Improve ExecModifyTable comments.
Date
Msg-id E1ddJLm-0004YZ-1g@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve ExecModifyTable comments.

Some of these comments wrongly implied that only an AFTER ROW trigger
will cause a 'wholerow' attribute to be present for a foreign table,
but a BEFORE ROW trigger can have the same effect.  Others implied
that it would always be present for a foreign table, but that's not
true either.

Etsuro Fujita and Robert Haas

Discussion: http://postgr.es/m/10026bc7-1403-ef85-9e43-c6100c1cc0e3@lab.ntt.co.jp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/12a34f59bf8bc5babf375c95f5192d208dca1739

Modified Files
--------------
src/backend/executor/nodeModifyTable.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: [COMMITTERS] pgsql: Teach map_partition_varattnos to handle whole-row expressions.
Next
From: Robert Haas
Date:
Subject: [COMMITTERS] pgsql: Allow a foreign table CHECK constraint to be initially NOTVALID