[COMMITTERS] pgsql: Remove broken and useless entry-count printing in HASH_DEBUGcod - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Remove broken and useless entry-count printing in HASH_DEBUGcod
Date
Msg-id E1dcwKg-0001KT-L4@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove broken and useless entry-count printing in HASH_DEBUG code.

init_htab(), with #define HASH_DEBUG, prints a bunch of hashtable
parameters.  It used to also print nentries, but commit 44ca4022f changed
that to "hash_get_num_entries(hctl)", which is wrong (the parameter should
be "hashp").

Rather than correct the coding, though, let's just remove that field from
the printout.  The table must be empty, since we just finished building
it, so expensively calculating the number of entries is rather pointless.
Moreover hash_get_num_entries makes assumptions (about not needing locks)
which we could do without in debugging code.

Noted by Choi Doo-Won in bug #14764.  Back-patch to 9.6 where the
faulty code was introduced.

Discussion: https://postgr.es/m/20170802032353.8424.12274@wrigleys.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9d4e56699957b261390c50dcda7f947470017484

Modified Files
--------------
src/backend/utils/hash/dynahash.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: [COMMITTERS] pgsql: Get a snapshot before COPY in table sync
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Silence warning from modern perl about unescaped braces