[COMMITTERS] pgsql: Move ExecProcNode from dispatch to function pointer basedmodel. - Mailing list pgsql-committers

Move ExecProcNode from dispatch to function pointer based model.

This allows us to add stack-depth checks the first time an executor
node is called, and skip that overhead on following
calls. Additionally it yields a nice speedup.

While it'd probably have been a good idea to have that check all
along, it has become more important after the new expression
evaluation framework in b8d7f053c5c2bf2a7e - there's no stack depth
check in common paths anymore now. We previously relied on
ExecEvalExpr() being executed somewhere.

We should move towards that model for further routines, but as this is
required for v10, it seems better to only do the necessary (which
already is quite large).

Author: Andres Freund, Tom Lane
Reported-By: Julien Rouhaud
Discussion:
    https://postgr.es/m/22833.1490390175@sss.pgh.pa.us
    https://postgr.es/m/b0af9eaa-130c-60d0-9e4e-7a135b1e0c76@dalibo.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cc9f08b6b813e30789100b6b34110d8be1090ba0

Modified Files
--------------
src/backend/executor/execProcnode.c            | 252 +++++++------------------
src/backend/executor/nodeAgg.c                 |   6 +-
src/backend/executor/nodeAppend.c              |   8 +-
src/backend/executor/nodeBitmapAnd.c           |  14 ++
src/backend/executor/nodeBitmapHeapscan.c      |   7 +-
src/backend/executor/nodeBitmapIndexscan.c     |  14 ++
src/backend/executor/nodeBitmapOr.c            |  14 ++
src/backend/executor/nodeCtescan.c             |   7 +-
src/backend/executor/nodeCustom.c              |  11 +-
src/backend/executor/nodeForeignscan.c         |   9 +-
src/backend/executor/nodeFunctionscan.c        |   7 +-
src/backend/executor/nodeGather.c              |   7 +-
src/backend/executor/nodeGatherMerge.c         |   7 +-
src/backend/executor/nodeGroup.c               |   6 +-
src/backend/executor/nodeHash.c                |   5 +-
src/backend/executor/nodeHashjoin.c            |   6 +-
src/backend/executor/nodeIndexonlyscan.c       |   7 +-
src/backend/executor/nodeIndexscan.c           |   7 +-
src/backend/executor/nodeLimit.c               |   6 +-
src/backend/executor/nodeLockRows.c            |   6 +-
src/backend/executor/nodeMaterial.c            |   6 +-
src/backend/executor/nodeMergeAppend.c         |   7 +-
src/backend/executor/nodeMergejoin.c           |   6 +-
src/backend/executor/nodeModifyTable.c         |   6 +-
src/backend/executor/nodeNamedtuplestorescan.c |   7 +-
src/backend/executor/nodeNestloop.c            |   6 +-
src/backend/executor/nodeProjectSet.c          |   6 +-
src/backend/executor/nodeRecursiveunion.c      |   6 +-
src/backend/executor/nodeResult.c              |   6 +-
src/backend/executor/nodeSamplescan.c          |   9 +-
src/backend/executor/nodeSeqscan.c             |   9 +-
src/backend/executor/nodeSetOp.c               |   6 +-
src/backend/executor/nodeSort.c                |   6 +-
src/backend/executor/nodeSubqueryscan.c        |   7 +-
src/backend/executor/nodeTableFuncscan.c       |   7 +-
src/backend/executor/nodeTidscan.c             |   7 +-
src/backend/executor/nodeUnique.c              |   6 +-
src/backend/executor/nodeValuesscan.c          |   7 +-
src/backend/executor/nodeWindowAgg.c           |   6 +-
src/backend/executor/nodeWorktablescan.c       |   7 +-
src/include/executor/executor.h                |  21 ++-
src/include/executor/nodeAgg.h                 |   1 -
src/include/executor/nodeAppend.h              |   1 -
src/include/executor/nodeBitmapHeapscan.h      |   1 -
src/include/executor/nodeCtescan.h             |   1 -
src/include/executor/nodeCustom.h              |   1 -
src/include/executor/nodeForeignscan.h         |   1 -
src/include/executor/nodeFunctionscan.h        |   1 -
src/include/executor/nodeGather.h              |   1 -
src/include/executor/nodeGatherMerge.h         |   1 -
src/include/executor/nodeGroup.h               |   1 -
src/include/executor/nodeHash.h                |   1 -
src/include/executor/nodeHashjoin.h            |   1 -
src/include/executor/nodeIndexonlyscan.h       |   1 -
src/include/executor/nodeIndexscan.h           |   1 -
src/include/executor/nodeLimit.h               |   1 -
src/include/executor/nodeLockRows.h            |   1 -
src/include/executor/nodeMaterial.h            |   1 -
src/include/executor/nodeMergeAppend.h         |   1 -
src/include/executor/nodeMergejoin.h           |   1 -
src/include/executor/nodeModifyTable.h         |   1 -
src/include/executor/nodeNamedtuplestorescan.h |   1 -
src/include/executor/nodeNestloop.h            |   1 -
src/include/executor/nodeProjectSet.h          |   1 -
src/include/executor/nodeRecursiveunion.h      |   1 -
src/include/executor/nodeResult.h              |   1 -
src/include/executor/nodeSamplescan.h          |   1 -
src/include/executor/nodeSeqscan.h             |   1 -
src/include/executor/nodeSetOp.h               |   1 -
src/include/executor/nodeSort.h                |   1 -
src/include/executor/nodeSubqueryscan.h        |   1 -
src/include/executor/nodeTableFuncscan.h       |   1 -
src/include/executor/nodeTidscan.h             |   1 -
src/include/executor/nodeUnique.h              |   1 -
src/include/executor/nodeValuesscan.h          |   1 -
src/include/executor/nodeWindowAgg.h           |   1 -
src/include/executor/nodeWorktablescan.h       |   1 -
src/include/nodes/execnodes.h                  |  16 ++
78 files changed, 313 insertions(+), 299 deletions(-)