[COMMITTERS] pgsql: Sync listDbRoleSettings() with the rest of the world. - Mailing list pgsql-committers

Sync listDbRoleSettings() with the rest of the world.

listDbRoleSettings() handled its server version check randomly differently
from every other comparable function in describe.c, not only as to code
layout but also message wording.  It also leaked memory, because its
PQExpBuffer management was also unlike everyplace else (and wrong).

Also fix an error-case leak in add_tablespace_footer().

In passing, standardize the format of function header comments in
describe.c --- we usually put "/*" alone on a line.

Daniel Gustafsson, memory leak fixes by me

Discussion: https://postgr.es/m/3641F19B-336A-431A-86CE-A80562505C5E@yesql.se

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b884f629dcbac002a703ccaf0990d9467ae69a19

Modified Files
--------------
src/bin/psql/describe.c | 77 ++++++++++++++++++++++++++++---------------------
1 file changed, 44 insertions(+), 33 deletions(-)